[alsa-devel] [PATCH] ASoC: ics43432: Fix build errors

[Mark Brown]

On Mon, Aug 31, 2015 at 09:14:02AM +0200, Ricard Wanderlof wrote:
> On Fri, 28 Aug 2015, Mark Brown wrote:
> > On Fri, Aug 28, 2015 at 12:11:48PM +0200, Ricard Wanderlof wrote:

> > I'll apply this since it fixes a build issue but please as I said in reply 
> > to your earlier off list query send one patch per issue (as covered in 
> > SubmittingPatches) and try to provide useful changelogs describing the 
> > issue being fixed.

> I purposely grouped both the mismatched variable name and license name 
> into a single patch, because both cause build failures when I tested in an 
> x86 build, the latter resulting in:

That isn't important or helpful, they are still separate build failures
and should be sent as separate commits.

> I should have been more descriptive in the commit message though. I did 
> feel though that given the diff it was fairly obvious what the problems 
> were so I didn't think it needed further explanation and would only clog 
> up the commit log.

If the commit message is too bad I may not look at the patch.  Part of
the review is making sure that the commit message describes what the
changes are doing to help make sure that the commit does what the author
thinks it does.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150831/cc40cabe/attachment.sig>