[alsa-devel] [PATCH v2] ALSA: ac97: Switch to dev_pm_ops

Takashi Iwai tiwai at suse.de
Fri Aug 21 18:27:08 CEST 2015


On Fri, 21 Aug 2015 18:15:29 +0200,
Dmitry Torokhov wrote:
> 
> On Fri, Aug 21, 2015 at 10:25:59AM +0200, Takashi Iwai wrote:
> > On Fri, 21 Aug 2015 09:48:33 +0200,
> > Lars-Peter Clausen wrote:
> > > 
> > > Convert the ac97_bus from legacy suspend/resume callbacks to dev_pm_ops.
> > > 
> > > Since there isn't anything special to do at the bus level the bus driver
> > > does not have to implement any callbacks. The device driver core will
> > > automatically pick up and execute the device's PM ops.
> > > 
> > > As there is only a single AC'97 driver implementing suspend and resume,
> > > update both the core and driver at the same time to avoid unnecessary code
> > > churn.
> > > 
> > > While we are at it also drop the ifdefs around the suspend/resume functions
> > > to increase compile test coverage.
> > > 
> > > Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
> > > ---
> > > This patch touches code in both ALSA and the input subsystem. Ideally this
> > > patch will be merged via the ALSA tree. Given that the wm97xx touchscreen
> > > driver is not seeing too many changes these days the risk of conflicts
> > > should be low.
> > 
> > If Dmitry is happy with this, I'll take this.
> 
> Sounds good to me.
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>

Mark, did you already put into your tree?  Otherwise I'm going to take
it to for-next branch.


thanks,

Takashi


More information about the Alsa-devel mailing list