[alsa-devel] [PATCH] ASoC: rt5677: handle reset_pin logical state correctly

[Mark Brown]

On Fri, Jul 17, 2015 at 10:38:56AM -0700, Anatol Pomozov wrote:
> According to the datasheet RESET is active low pin, i.e. system goes to reset
> state when pin is low.
> 
> Handle logic state correctly - set reset_pin to logical 0 at boot time, and
> set it to logical 1 when we need to reset the chip.

I'm a bit confused here - how was the original code (written by you it
seems...) tested?  This looks like it's fixing the device being held in
reset when it should be operation which seems like something that'd get
noticed.  Are there existing systems that the current code works for
which we need to handle here?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150814/cea51970/attachment-0001.sig>