[alsa-devel] [PATCH] ALSA: usb-audio: Fix parameter block size for UAC2 control requests

[Julian Scheel]

Am 14.08.2015 um 15:51 schrieb Takashi Iwai:
> On Fri, 14 Aug 2015 15:45:58 +0200,
> Julian Scheel wrote:
>>
>> Am 14.08.2015 um 15:17 schrieb Takashi Iwai:
>>> On Thu, 13 Aug 2015 13:04:46 +0200,
>>> Julian Scheel wrote:
>>>>
>>>> @@ -469,6 +503,8 @@ int snd_usb_mixer_set_ctl_value(struct usb_mixer_elem_info *cval,
>>>>    	value_set = convert_bytes_value(cval, value_set);
>>>>    	buf[0] = value_set & 0xff;
>>>>    	buf[1] = (value_set >> 8) & 0xff;
>>>> +	buf[2] = (value_set >> 16) & 0xff;
>>>> +	buf[3] = (value_set >> 24) & 0xff;
>>>
>>> It's not smart but OK, just a subtle matter...
>>
>> Hm, what would you like better?
>
> A shorter code would be to to pass __le32 value pointer directly after
> calling cpu_to_le32(), for example.  But it's a matter of taste, so
> it's OK to keep your code as is.

Thanks, I'll leave it as is for now and keep the le32 approach in mind 
for the future.