[alsa-devel] [PATCH] jack: Fixing a small memory leak

Takashi Iwai tiwai at suse.de
Mon Aug 10 17:09:57 CEST 2015


On Mon, 10 Aug 2015 16:58:26 +0200,
Valentin Corfu wrote:
> 
> Signed-off-by: Valentin Corfu <corfuvalentin at gmail.com>

So you found out the very same fix :)

But please put more description in the commit log.  For example, the
valgrind output you cited would be a good material.


thanks,

Takashi

> ---
>  jack/pcm_jack.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/jack/pcm_jack.c b/jack/pcm_jack.c
> index 568ec43..de9c46e 100644
> --- a/jack/pcm_jack.c
> +++ b/jack/pcm_jack.c
> @@ -103,6 +103,7 @@ static void snd_pcm_jack_free(snd_pcm_jack_t *jack)
>  		if (jack->io.poll_fd >= 0)
>  			close(jack->io.poll_fd);
>  		free(jack->areas);
> +		free(jack->ports);
>  		free(jack);
>  	}
>  }
> -- 
> 1.9.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 


More information about the Alsa-devel mailing list