[alsa-devel] Verb for 0x17 pin config

[Kailang]

Hi Takashi,

Update patch as attach.
Thanks.

BR,
Kailang
 

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de] 
> Sent: Wednesday, August 05, 2015 3:17 PM
> To: Kailang
> Cc: (alsa-devel at alsa-project.org)
> Subject: Re: Verb for 0x17 pin config
> 
> On Wed, 05 Aug 2015 09:07:06 +0200,
> Kailang wrote:
> > 
> >  
> > 
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai at suse.de]
> > > Sent: Wednesday, August 05, 2015 2:59 PM
> > > To: Kailang
> > > Cc: (alsa-devel at alsa-project.org)
> > > Subject: Re: Verb for 0x17 pin config
> > > 
> > > On Wed, 05 Aug 2015 08:42:03 +0200,
> > > Kailang wrote:
> > > > 
> > > > Hi Takashi,
> > > >  
> > > > commit
> > > > 
> > > 
> http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?
> > > id
> > > > =977e627684df0f60bdf2a768ec4772f42fe843fc
> > > > ALSA: hda/realtek - Support Dell headset mode for ALC298
> > > > 
> > > > Dell had use verb to do speaker preset. So, The same SSID
> > > maybe 0x17 verb was different.
> > > > 
> > > > 0x17 0x90170110
> > > > 0x17 0x90170140
> > > > 0x17 0x90170150
> > > > 
> > > > Upper verb will show on this case.
> > > > 
> > > > Could I change it to quirk for SSID?
> > > 
> > > It would be one option.  OTOH, right now we have a patch to add 
> > > 0x90170110, so the only missing is 0x90170150.  Just 
> adding it would 
> > > be an easier option, I suppose.
> > > 
> > So, you mean I add as below patch.
> > 
> > +	SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", 
> ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
> > +		ALC298_STANDARD_PINS,
> > +		{0x12, 0x90a60130},
> > +		{0x13, 0x40000000},
> > +		{0x14, 0x411111f0},
> > +		{0x17, 0x90170110},
> > +		{0x1d, 0x4068a36d},
> > +		{0x21, 0x03211020}),
> > 
> > +	SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", 
> ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
> > +		ALC298_STANDARD_PINS,
> > +		{0x12, 0x90a60130},
> > +		{0x13, 0x40000000},
> > +		{0x14, 0x411111f0},
> > +		{0x17, 0x90170150},
> > +		{0x1d, 0x4068a36d},
> > +		{0x21, 0x03211020}),
> > 
> > Right?
> 
> With the latest code, only the following would be needed:
> 
> @@ -5579,6 +5579,9 @@ static const struct snd_hda_pin_quirk 
> alc269_pin_fixup_tbl[] = {
>  	SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", 
> ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
>  		ALC298_STANDARD_PINS,
>  		{0x17, 0x90170110}),
> +	SND_HDA_PIN_QUIRK(0x10ec0298, 0x1028, "Dell", 
> ALC298_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		ALC298_STANDARD_PINS,
> +		{0x17, 0x90170150}),
>  	{}
>  };
>  
> 
> Takashi
> 
> ------Please consider the environment before printing this e-mail.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0000-new-verb-for-dell-headset-mode-for-alc298.patch
Type: application/octet-stream
Size: 945 bytes
Desc: 0000-new-verb-for-dell-headset-mode-for-alc298.patch
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150805/d9d9cfb2/attachment.obj>