[alsa-devel] [PATCH v2] ASoC: rt5645: Adds push button support for rt5650

Mark Brown broonie at kernel.org
Mon Apr 27 22:47:21 CEST 2015


On Wed, Apr 22, 2015 at 08:13:55PM +0800, bardliao at realtek.com wrote:

> Can we have a separate codec driver for rt5650?
> rt5650 will be more popular than rt5645. Many customers are searching
> rt5650.c but can't find one. We have to told them rt5650 and rt5645
> share the same codec driver. Also, some registers or functions are
> different between rt5645 and rt5650.

I really don't want to end up with a precedent for duplicating code due
to user confusion like this - it's something people are going to have to
get used to with Linux since it happens quite often and we don't want
code duplication.  However something like what the Wolfson drivers do
with sharing the common code in arizona.c and wm_hubs.c isn't a problem
at all. 

>  sound/soc/intel/cht_bsw_rt5645.c |   2 +-

This doesn't apply against current code, the Intel drivers have been
moved around and split into multiple directories.  Please redo against
current code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150427/10d67b0c/attachment.sig>


More information about the Alsa-devel mailing list