[alsa-devel] [PATCH] ASoC: dmaengine_pcm: Make FLAG_NO_RESIDUE internal

[Mark Brown]

On Mon, Apr 27, 2015 at 12:44:25PM +0200, Lars-Peter Clausen wrote:

> Whether residue can be reported or not is not a property of the audio
> controller but of the DMA controller. The FLAG_NO_RESIDUE was initially
> added when the DMAengine framework had no support for describing the residue
> reporting capabilities of the controller. Support for this was added quite a

Applied, thanks.

> This patch makes the FLAG_NO_RESIDUE internal and no longer allows audio
> controller drivers to manually set the flag. If a DMA driver against
> expectations does not support reporting its capabilities for now the generic
> DMAengine PCM driver will now emit a warning and simply assume that residue
> reporting is not supported. In the future this might be changed to aborting
> with an error.

I'm not sure it's ever going to buy us anything to error out on stuff,
it's not like the no residue case doesn't need to be supported anyway
for controllers that just can't do it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150427/a0f4efe3/attachment.sig>