[alsa-devel] [PATCH 4/7] Asoc: sti: add CPU DAI driver for capture

[Mark Brown]

On Tue, Apr 14, 2015 at 03:35:28PM +0200, Arnaud Pouliquen wrote:

> +const struct snd_pcm_hardware uni_reader_pcm_hw = {
> +	.info = (SNDRV_PCM_INFO_INTERLEAVED |
> +		 SNDRV_PCM_INFO_BLOCK_TRANSFER |
> +		 SNDRV_PCM_INFO_PAUSE),

The commit message says this is a CPU DAI but a snd_pcm_hardware is a
DMA controller.

> +static inline int get_property_hdl(struct device *dev, struct device_node *np,
> +				   const char *prop, int idx)

This appears to be duplicated from the previous patch, as does a *lot*
of the code here.  Can we not share more of the code between playback
and capture paths?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150424/7dede655/attachment.sig>