[alsa-devel] [PATCH v2 7/7] ASoC: hda - added Skylake I2S machine driver

[Vinod Koul]

On Fri, Apr 17, 2015 at 09:14:13PM +0200, Lars-Peter Clausen wrote:
> On 04/17/2015 09:06 PM, Vinod Koul wrote:
> >On Fri, Apr 17, 2015 at 11:44:50AM +0200, Lars-Peter Clausen wrote:
> >>On 04/17/2015 11:13 AM, Vinod Koul wrote:
> >>[...]
> >>>+	/* always connected - check HP for jack detect */
> >>>+	snd_soc_dapm_enable_pin(dapm, "Headphone Jack");
> >>>+	snd_soc_dapm_enable_pin(dapm, "Speaker");
> >>>+	snd_soc_dapm_enable_pin(dapm, "Mic Jack");
> >>>+	snd_soc_dapm_enable_pin(dapm, "DMIC2");
> >>
> >>There is no need to do this, all pins are enabled by default.
> >Ah yes, thanks for pointing. With this I should also set full_routed right?
> 
> You don't have to, the two are unrelated. But I'd still recommend
> setting fully_routed.
Yes I will set this in next patch, thanks

-- 
~Vinod