[alsa-devel] [PATCH 01/14] parport: return value of attach and parport_register_driver

Dan Carpenter dan.carpenter at oracle.com
Wed Apr 8 13:38:32 CEST 2015


1) We can't apply this patch on its own so this way of breaking up the
patches doesn't work.

2) I was thinking that all the ->attach() calls would have to succeed or
we would bail.  Having some of them succeed and some fail doesn't seem
like it will simplify the driver code very much.  But I can also see
your point.  Hm...

Minor comment:  No need to preserve the error code if there are lots
which we miss.  We may as well hard code an error code.  But that's a
minor thing.  Does this actually simplify the driver code?  That's the
more important thing.

regards,
dan carpenter



More information about the Alsa-devel mailing list