[alsa-devel] [PATCH 8/9] sound/pci/rme9652/hdspm.c: fix error return code
Julia Lawall
julia.lawall at lip6.fr
Sun Apr 5 14:13:24 CEST 2015
Please ignore. Wrong patch set.
On Sun, 5 Apr 2015, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall at lip6.fr>
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if at p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret at p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
>
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
>
> ---
> sound/pci/rme9652/hdspm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
> index b8ac871..b12308b 100644
> --- a/sound/pci/rme9652/hdspm.c
> +++ b/sound/pci/rme9652/hdspm.c
> @@ -6585,7 +6585,7 @@ static int __devinit snd_hdspm_create(struct snd_card *card,
> snd_printk(KERN_ERR "HDSPM: "
> "unable to kmalloc Mixer memory of %d Bytes\n",
> (int)sizeof(struct hdspm_mixer));
> - return err;
> + return -ENOMEM;
> }
>
> hdspm->port_names_in = NULL;
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
More information about the Alsa-devel
mailing list