[alsa-devel] [RFC 1/3] ALSA: hda - remove assigning dev type inside core

[Takashi Iwai]

At Thu,  2 Apr 2015 15:27:29 +0530,
Vinod Koul wrote:
> 
> From: Ramesh Babu <ramesh.babu at intel.com>
> 
> We don't need to init the hda dev type inside
> core device init code. It is expected to be
> initialized by the caller.

As there is no way in C to guarantee the initialization of some
virtual fields in the inherited class, it's safer to do the complete
init in the base class initializer and let the child class override
manually.


Takashi

> 
> Signed-off-by: Ramesh Babu <ramesh.babu at intel.com>
> Signed-off-by: Vinod Koul <vinod.koul at intel.com>
> ---
>  sound/hda/hdac_device.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c
> index 6e8ee1d6974a..aefc80ffecee 100644
> --- a/sound/hda/hdac_device.c
> +++ b/sound/hda/hdac_device.c
> @@ -51,7 +51,6 @@ int snd_hdac_device_init(struct hdac_device *codec, struct hdac_bus *bus,
>  
>  	codec->bus = bus;
>  	codec->addr = addr;
> -	codec->type = HDA_DEV_CORE;
>  	pm_runtime_set_active(&codec->dev);
>  	pm_runtime_get_noresume(&codec->dev);
>  	atomic_set(&codec->in_pm, 0);
> -- 
> 1.7.9.5
>