[alsa-devel] [PATCH] ASoC: ssm4567: Add driver for Analog Devices SSM4567 amplifier

[Mark Brown]

On Fri, Sep 26, 2014 at 01:31:06PM -0700, Anatol Pomozov wrote:
> Analog Devices SSM4567 is a boost class-D audio amplifier.

Applied, but don't send patches in reply to existing threads especially
if you don't include a version tag in the header.  This was very nearly
deleted unread.  One thing to look at incrementally:

> +               ret = regmap_update_bits(ssm4567->regmap,
> +                       SSM4567_REG_POWER_CTRL,
> +                       SSM4567_POWER_SPWDN, 0x00);
> +               regcache_sync(ssm4567->regmap);

This checks the return value of _update_bits() but not _sync() - make
your mind up please!  I'd also split the _set_power() function into two,
there is much more conditional code for the two cases than common code
in there.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140927/d83526e1/attachment.sig>