[alsa-devel] [PATCH v2 01/11] mixer : fixed double free
Takashi Iwai
tiwai at suse.de
Tue Sep 23 09:28:57 CEST 2014
At Tue, 23 Sep 2014 04:13:02 +0000 (GMT),
Renu Tyagi wrote:
>
> Hi Takashi,
> I will prefer "renu tyagi".
> I cannot use git send-email from my organization.
> I will resubmit patches where I missed email id in signoff. Or you can see the attachments as they are fine.
> If any other issues I will be happy to respond.
The attachment itself should contain all headers, From and Subject,
not only signed-off-by, to be applicable directly via git-am.
But I'm off for this week and I don't want the iteration again, so I
applied all patches now by manually editing. The above is common for
most projects working with git, so it's good to learn it once.
thanks,
Takashi
> Thanks
>
> --------------------------------------------
> Signed-off-by: renu tyagi <renu.tyagi at samsung.com>
> ---
> src/mixer/mixer.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/src/mixer/mixer.c b/src/mixer/mixer.c
> index 56e023d..eee9875 100644
> --- a/src/mixer/mixer.c
> +++ b/src/mixer/mixer.c
> @@ -204,10 +204,8 @@ int snd_mixer_attach(snd_mixer_t *mixer, const char *name)
> if (err < 0)
> return err;
> err = snd_mixer_attach_hctl(mixer, hctl);
> - if (err < 0) {
> - snd_hctl_close(hctl);
> + if (err < 0)
> return err;
> - }
> return 0;
> }
>
> --
> 1.7.1
More information about the Alsa-devel
mailing list