[alsa-devel] [PATCH v2] ASoC: rt286: Set cbj_en for ACPI devices

[Mark Brown]

On Thu, Sep 11, 2014 at 09:40:54AM +0800, bardliao at realtek.com wrote:

> +/* the default platform data for acpi devices */
> +static struct rt286_platform_data rt286_acpi_data = {
> +	.cbj_en = true,
> +	.gpio2_en = false,
> +};
> +
>  static const struct acpi_device_id rt286_acpi_match[] = {
> -	{ "INT343A", 0 },
> +	{ "INT343A", (unsigned long)&rt286_acpi_data },
>  	{},
>  };

Why does this platform data apply to all boards using this ACPI ID?
Shouldn't this be _DSD data instead, or should we be doing quirks based
on DMI data?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140912/6a147b3f/attachment-0001.sig>