[alsa-devel] [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

Timur Tabi timur at tabi.org
Tue Sep 9 17:24:00 CEST 2014


On 09/09/2014 10:21 AM, Mark Brown wrote:
>> if (ssi_private->clk)
>> >	clk_prepare_enable(ssi_private->clk);

> Should be a !IS_ERR() - NULL is a valid clock.

In that case, ssi_private->clk needs to be initialized to -EINVAL or 
something, so that the check works on systems that don't have any clocks.


More information about the Alsa-devel mailing list