[alsa-devel] [PATCH v2] ASoC: rt5670: add clock source selection controls

[Mark Brown]

On Mon, Sep 01, 2014 at 01:37:58PM +0800, bardliao at realtek.com wrote:

> I write the changelog at the beginning of rt5670.c. But I am not
> sure if it is a regular way to make a changelog.

No, please don't do this - in the kernel we just use git for the
changelog, there's no need for additional changelogs in files.

> +static const char * const rt5670_asrc_clk_source[] = {
> +	"clk_sysy_div_out", "clk_i2s1_track", "clk_i2s2_track",
> +	"clk_i2s3_track", "clk_i2s4_track", "clk_sys2", "clk_sys3",
> +	"clk_sys4", "clk_sys5"
> +};

Every time I see this patch I raise the same concern about the clocking
usually being controlled in the kernel since other clocks are controlled
within the kernel.  I've not seen a response to this yet - it's possible
there is a good reason for putting this under userspace control but you
need to make the case for doing that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140901/5a1e9c22/attachment.sig>