[alsa-devel] [PATCH - hda 1/1] Add ultra dock support for Thinkpad X240.

[Takashi Iwai]

At Tue, 28 Oct 2014 22:15:02 +0100,
Lukas Bossard wrote:
> 
> Adding ultra doch support for Lenovo Thinkpad X240
> (17aa:2214). In the same process also rename
> ALC292_FIXUP_TPT440_DOCK to a more generic
> ALC292_FIXUP_LENOVO_ULTRA_DOCK

Please don't rename.  This break the user who's using the option.
It's just a name, not a code, so there isn't any big win by such an
action.

So, please resubmit a patch just adding the missing id.


thanks,

Takashi

> 
> Signed-off-by: Lukas Bossard <mr.bobukas at gmail.com>
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 34b7bdb..693f083 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4212,7 +4212,7 @@ enum {
>  	ALC255_FIXUP_HEADSET_MODE,
>  	ALC255_FIXUP_HEADSET_MODE_NO_HP_MIC,
>  	ALC293_FIXUP_DELL1_MIC_NO_PRESENCE,
> -	ALC292_FIXUP_TPT440_DOCK,
> +	ALC292_FIXUP_LENOVO_ULTRA_DOCK,
>  	ALC283_FIXUP_BXBT2807_MIC,
>  	ALC255_FIXUP_DELL_WMI_MIC_MUTE_LED,
>  	ALC282_FIXUP_ASPIRE_V5_PINS,
> @@ -4640,7 +4640,7 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.chained = true,
>  		.chain_id = ALC269_FIXUP_HEADSET_MODE
>  	},
> -	[ALC292_FIXUP_TPT440_DOCK] = {
> +	[ALC292_FIXUP_LENOVO_ULTRA_DOCK] = {
>  		.type = HDA_FIXUP_PINS,
>  		.v.pins = (const struct hda_pintbl[]) {
>  			{ 0x16, 0x21211010 }, /* dock headphone */
> @@ -4799,16 +4799,17 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x21fb, "Thinkpad T430s", ALC269_FIXUP_LENOVO_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2203, "Thinkpad X230 Tablet", ALC269_FIXUP_LENOVO_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2208, "Thinkpad T431s", ALC269_FIXUP_LENOVO_DOCK),
> -	SND_PCI_QUIRK(0x17aa, 0x220c, "Thinkpad T440s", ALC292_FIXUP_TPT440_DOCK),
> -	SND_PCI_QUIRK(0x17aa, 0x220e, "Thinkpad T440p", ALC292_FIXUP_TPT440_DOCK),
> -	SND_PCI_QUIRK(0x17aa, 0x2210, "Thinkpad T540p", ALC292_FIXUP_TPT440_DOCK),
> -	SND_PCI_QUIRK(0x17aa, 0x2212, "Thinkpad T440", ALC292_FIXUP_TPT440_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad X240", ALC292_FIXUP_LENOVO_ULTRA_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x2212, "Thinkpad T440", ALC292_FIXUP_LENOVO_ULTRA_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x220c, "Thinkpad T440s", ALC292_FIXUP_LENOVO_ULTRA_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x220e, "Thinkpad T440p", ALC292_FIXUP_LENOVO_ULTRA_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x2210, "Thinkpad T540p", ALC292_FIXUP_LENOVO_ULTRA_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP),
>  	SND_PCI_QUIRK(0x17aa, 0x5013, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x501a, "Thinkpad", ALC283_FIXUP_INT_MIC),
> -	SND_PCI_QUIRK(0x17aa, 0x501e, "Thinkpad L440", ALC292_FIXUP_TPT440_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x501e, "Thinkpad L440", ALC292_FIXUP_LENOVO_ULTRA_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x5026, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
> @@ -4887,7 +4888,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>  	{.id = ALC269_FIXUP_DELL2_MIC_NO_PRESENCE, .name = "dell-headset-dock"},
>  	{.id = ALC283_FIXUP_CHROME_BOOK, .name = "alc283-dac-wcaps"},
>  	{.id = ALC283_FIXUP_SENSE_COMBO_JACK, .name = "alc283-sense-combo"},
> -	{.id = ALC292_FIXUP_TPT440_DOCK, .name = "tpt440-dock"},
> +	{.id = ALC292_FIXUP_LENOVO_ULTRA_DOCK, .name = "lenovo-ultra-dock"},
>  	{}
>  };
>  
> -- 
> 2.1.0
>