[alsa-devel] [PATCH 1/3] ASoC: sgtl5000: Use the preferred form for passing a size of a struct
Fabio Estevam
festevam at gmail.com
Fri Oct 24 17:01:25 CEST 2014
From: Fabio Estevam <fabio.estevam at freescale.com>
According to Documentation/CodingStyle - Chapter 14:
"The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not."
So do it as recommeded.
Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
---
sound/soc/codecs/sgtl5000.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 6bb77d7..3f8c05b 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -1419,8 +1419,7 @@ static int sgtl5000_i2c_probe(struct i2c_client *client,
int ret, reg, rev;
unsigned int mclk;
- sgtl5000 = devm_kzalloc(&client->dev, sizeof(struct sgtl5000_priv),
- GFP_KERNEL);
+ sgtl5000 = devm_kzalloc(&client->dev, sizeof(*sgtl5000), GFP_KERNEL);
if (!sgtl5000)
return -ENOMEM;
--
1.9.1
More information about the Alsa-devel
mailing list