[alsa-devel] [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

Bo Shen voice.shen at atmel.com
Fri Oct 24 10:43:13 CEST 2014


Hi Peter,

On 10/24/2014 03:13 PM, Peter Rosin wrote:
>> Hi Peter,
>>     Thanks for your patch.
>
> And thanks for the Ack!
>
>>     Btw, do you use "git send-email" command to send the patch?
>
> No, I  didn't, "git format-patch" and paste into the mail body. Was there some
> whitespace issues with the patch?

If you paste the patch in mail body, after apply your patch, git log 
will show information look like:
--->8---
commit bfb9419839caeca07aa3e99c141fc7c1ac4f37af
Author: Peter Rosin <peda at axentia.se>
Date:   Wed Oct 22 15:13:55 2014 +0000

     ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

     From 86be84c4de4e7b21cfda9656a02a902c543210af Mon Sep 17 00:00:00 2001
     From: Peter Rosin <peda at axentia.se>
     Date: Wed, 22 Oct 2014 16:45:29 +0200
     Subject: [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only 
in full
      duplex.

     The CMR divider register is shared by playback and capture. The SSC 
driver
     therefore tries to enforce rules so that the needed register content do
     not conflict during simultaneous playback/capture. However, the
     implementation also prevents changing the register content in
     half-duplex scenarios, which is needed when using the OSS API.
---8<---

If you send patch use "git send-email", after apply your patch, git log 
will show information look like

--->8---
commit bfb9419839caeca07aa3e99c141fc7c1ac4f37af
Author: Peter Rosin <peda at axentia.se>
Date:   Wed Oct 22 15:13:55 2014 +0000

     The CMR divider register is shared by playback and capture. The SSC 
driver
     therefore tries to enforce rules so that the needed register content do
     not conflict during simultaneous playback/capture. However, the
     implementation also prevents changing the register content in
     half-duplex scenarios, which is needed when using the OSS API.

---8<---

> Cheers,
> Peter
>

Best Regards,
Bo Shen


More information about the Alsa-devel mailing list