[alsa-devel] [PATCH v4 4/7] ASoC: Intel: sst: Add IPC handling

[Vinod Koul]

On Fri, Oct 17, 2014 at 03:53:14PM +0200, Mark Brown wrote:
> On Fri, Oct 17, 2014 at 05:25:24PM +0530, Vinod Koul wrote:
> > On Fri, Oct 17, 2014 at 02:09:18PM +0200, Mark Brown wrote:
> 
> > > Shouldn't this be a dev_err() or something?
> 
> > Not really.
> 
> > We get response from FW which cna be short or long. In former there wont be
> > anyone waiting as all blocked ones are large.
> > We cant distiguish between the two thats why we log debug message here. If
> > its real then finally the message will timeout and we would see that as
> > error. Yes this is limiation in IPC.
> > Putting this as err makes log very noisy :(
> 
> OK, perhaps a comment explaining that the firmware generates lots of
> false positives might be in order?
Sure, that sound okay to me.
I will send that in fixes for these

-- 
~Vinod
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141020/4d0c85a9/attachment.sig>