[alsa-devel] [PATCH] ASoC: tegra: Add platform driver for rt5677 audio codec

[Mark Brown]

On Thu, Oct 16, 2014 at 01:59:58AM -0700, Anatol Pomazau wrote:
> On Thu, Oct 16, 2014 at 12:38 AM, Mark Brown <broonie at kernel.org> wrote:
> > On Wed, Oct 15, 2014 at 02:15:42PM -0700, Anatol Pomozov wrote:

> >> +Required properties:
> >> +- nvidia,speaker-codec: The phandle of the board specific speaker amplifier.
> >> +  This binding assumes that AIF2 on the audio CODEC is connected to this
> >> +  amplifier.

> > To repeat my comment on the previous version:

> > | This isn't as generic as all that, it relies on the specific speaker
> > | driver.  I'd suggest either just saying it's board specific or making
> > | the speaker CODEC optional.

> > Please don't ignore review comments.

> In the description of the dts property I said that its board specific
> amp. If it not what you want then I do not know what "saying it's
> board specific" means. Could you please provide examples of "board
> specific" properties?

The *driver* is board specific.  Obviously all DT properties in a given
DT are specific to the particular board.  This driver claims to be a
generic driver for Tegra systems with this CODEC but it has a
non-optional requirement for an external speaker driver driver to be
specified and hooked up in that particular way.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141016/92850376/attachment.sig>