[alsa-devel] [PATCH] ASoC: tegra: Add platform driver for rt5677 audio codec

[Mark Brown]

On Wed, Oct 15, 2014 at 02:15:42PM -0700, Anatol Pomozov wrote:

> +Required properties:
> +- nvidia,speaker-codec: The phandle of the board specific speaker amplifier.
> +  This binding assumes that AIF2 on the audio CODEC is connected to this
> +  amplifier.

To repeat my comment on the previous version:

| This isn't as generic as all that, it relies on the specific speaker
| driver.  I'd suggest either just saying it's board specific or making
| the speaker CODEC optional.

Please don't ignore review comments.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141016/8e9b7d4b/attachment.sig>