[alsa-devel] [PATCH v2] ASoC: rt5677: Support DSP function for VAD application

[Mark Brown]

On Mon, Oct 06, 2014 at 04:30:51PM +0800, Oder Chiou wrote:
> The ALC5677 has a programmable DSP, and there is a SPI that is dadicated for DSP
> firmware loading. Therefore, the patch includes a SPI driver for writing the DSP
> firmware. The VAD(Voice Activaty Detection) has be implemented and use the DSP to
> recognize the key phase.

Applied, thanks.  One small thing which I fixed up:

> +static struct spi_driver rt5677_spi_driver = {
> +	.driver = {
> +			.name = "rt5677_spidev",
> +			.bus = &spi_bus_type,
> +			.owner = THIS_MODULE,
> +	},
> +	.probe = rt5677_spi_probe,
> +};
> +module_spi_driver(rt5677_spi_driver);

It is better form to remove the _spidev from the name.  I fixed this,
the indentation and the redundant .bus initialization.

We really should do something better to tie the two devices together
though - but I'm not quite seeing the elegant thing.  I'm wondering if
the I2C driver should defer probe until the SPI driver is there.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141014/e7298e83/attachment.sig>