[alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*
Raymond Yau
superquad.vortex2 at gmail.com
Sat Oct 11 09:20:56 CEST 2014
>
> pr_* macros replaced with dev_* as they are more preffered over pr_*.
> each file which had pr_* was reviewed manually and replaced with dev_*.
> here we have actually used the reference of the vortex which was added
> to some functions in the previous patch of this series.
>
> The prefix of the CARD_NAME and prefix of "vortex:" was also
> removed as the dev_* will print the device name.
>
> Signed-off-by: Sudip Mukherjee <sudip at vectorindia.org>
> ---
>
> static int vortex_core_init(vortex_t *vortex)
> {
>
> - pr_info( "Vortex: init.... ");
> + dev_info(vortex->card->dev, "init.... ");
Is it possible to add linefeed since "done/n" won't appear in the same
line with init nor shutdown?
> /* Hardware Init. */
> hwwrite(vortex->mmio, VORTEX_CTRL, 0xffffffff);
> msleep(5);
> @@ -2729,7 +2735,7 @@ static int vortex_core_init(vortex_t *vortex)
> //vortex_enable_timer_int(vortex);
> //vortex_disable_timer_int(vortex);
>
> - pr_info( "done.\n");
> + dev_info(vortex->card->dev, "done.\n");
> spin_lock_init(&vortex->lock);
>
> return 0;
> @@ -2738,7 +2744,7 @@ static int vortex_core_init(vortex_t *vortex)
> static int vortex_core_shutdown(vortex_t * vortex)
> {
>
> - pr_info( "Vortex: shutdown...");
> + dev_info(vortex->card->dev, "shutdown...");
> #ifndef CHIP_AU8820
> vortex_eq_free(vortex);
> vortex_Vort3D_disable(vortex);
> @@ -2760,7 +2766,7 @@ static int vortex_core_shutdown(vortex_t * vortex)
> msleep(5);
> hwwrite(vortex->mmio, VORTEX_IRQ_SOURCE, 0xffff);
>
> - pr_info( "done.\n");
> + dev_info(vortex->card->dev, "done.\n");
> return 0;
> }
>
More information about the Alsa-devel
mailing list