[alsa-devel] [PATCH] bebob: Fix failure to detect source of clock for Terratec Phase 88

[Takashi Iwai]

At Fri, 10 Oct 2014 23:32:49 +0900,
Takashi Sakamoto wrote:
> 
> This patch fixes a failure to open PCM device with -ENOSYS in
> Terratec Phase 88.
> 
> Terratec Phase 88 has two Selector Function Blocks of AVC Audio subunit
> to switch source of clock. One is to switch internal/external for the
> source and another is to switch word/spdif for the external clock.
> 
> The IDs for these Selector Function Blocks are 9 and 8. But in current
> implementation they're 0 and 0.
> 
> Reported-by: András Murányi <muranyia at gmail.com>
> Tested-by: András Murányi <muranyia at gmail.com>
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

This deserves Cc to stable kernel, right?


Takashi

> ---
>  sound/firewire/bebob/bebob_terratec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/firewire/bebob/bebob_terratec.c b/sound/firewire/bebob/bebob_terratec.c
> index eef8ea7..0e4c0bf 100644
> --- a/sound/firewire/bebob/bebob_terratec.c
> +++ b/sound/firewire/bebob/bebob_terratec.c
> @@ -17,10 +17,10 @@ phase88_rack_clk_src_get(struct snd_bebob *bebob, unsigned int *id)
>  	unsigned int enable_ext, enable_word;
>  	int err;
>  
> -	err = avc_audio_get_selector(bebob->unit, 0, 0, &enable_ext);
> +	err = avc_audio_get_selector(bebob->unit, 0, 9, &enable_ext);
>  	if (err < 0)
>  		goto end;
> -	err = avc_audio_get_selector(bebob->unit, 0, 0, &enable_word);
> +	err = avc_audio_get_selector(bebob->unit, 0, 8, &enable_word);
>  	if (err < 0)
>  		goto end;
>  
> -- 
> 1.9.1
>