[alsa-devel] [PATCH 1/1] ALSA: ALC283 codec - Avoid pop noise on headphones during suspend/resume

[Takashi Iwai]

At Thu,  9 Oct 2014 11:04:56 +0000,
Harsha Priya wrote:
> 
> This patch sets the headphones mode to default before suspending
> which helps avoid the pop noise on headphones

The change looks simple, but since it's a mysterious COEF, I'd like to
hear from people testing with other machines with this codec before
applying the patch.

David, do you know anyone in your team have such a machine to test?


thanks,

Takashi

> 
> Signed-off-by: Harsha Priya <harshapriya.n at intel.com>
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 69d1236..e839e7a 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -2884,6 +2884,9 @@ static void alc283_shutup(struct hda_codec *codec)
>  
>  	alc_write_coef_idx(codec, 0x43, 0x9004);
>  
> +	/*depop hp during suspend*/
> +	alc_write_coef_idx(codec, 0x06, 0x2100);
> +
>  	snd_hda_codec_write(codec, hp_pin, 0,
>  			    AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
>  
> -- 
> 1.9.1
>