[alsa-devel] [PATCH 1/4] ASoC: mc13783: Fix of_node_put() call with uninitialized object

[Takashi Iwai]

At Wed, 8 Oct 2014 00:01:50 +0100,
Mark Brown wrote:
> 
> On Tue, Oct 07, 2014 at 08:58:38PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > That looks ugly, yes - I'd be doing a check for ret before the second
> > > property call or something.  Or just put the pdata check in the existing
> > > error path.
> 
> > Well, I don't mind much how it'll be fixed, so I rather toss this fix
> > to you.  Feel free to cook :)
> 
> Well, I can't even see the warning so as far as I can tell it's all
> fixed!

Oh, rather trust your eyes, the fault is there obviously.
It's a real bug that can be easily triggered, not in an exceptional
error path.

BTW, putting pdata check in the exit path is more error-prone, as
already mentioned.  If anyone puts a new code with "goto out" before
assignment of np, it hits again.  So, a NULL initialization would be
safer in the end.


Takashi