[alsa-devel] [PATCH RESEND] ASoC: rt5670: Add dsp support

[Mark Brown]

On Mon, Oct 06, 2014 at 02:18:47AM +0000, Bard Liao wrote:

> > > +/* DSP Mode */
> > > +static const char * const rt5670_dsp_mode[] = {
> > > +	"Mode 1", "Mode 2", "Mode 3", "Mode 4", "Mode 5"
> > > +};

> > What exactly are these modes?

> These are DSP working modes, such as noise suppression, echo cancellation...
> The reason we won't have a specific name on alsa control is that the driver
> will be more flexible and we can define customized modes on the firmware.
> For example, the 5 modes may be noise suppression 1, noise suppression 2,
> noise suppression + echo cancellation, voice tracking, echo cancellation.

That's not really good for users, it means that their configuration
silently depends on the firmware they're using so a new firmware version
could break things non-obviously and the control might not work for some
values if one of the modes is unused.  What would be much better would
be if the firmware were to describe the modes it implements (this could
be done as metadata rather than as a part of the image being downloaded)
then we can read the modes at runtime and match them up with the
control.

As things stand this may as well just be a plain numeric control.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141007/f7dfa60d/attachment.sig>