[alsa-devel] [PATCH RESEND] ASoC: rt5670: Add dsp support

[Mark Brown]

On Mon, Sep 29, 2014 at 10:31:41AM +0800, Bard Liao wrote:

> +static const struct firmware *rt5670_dsp_fw;

This should be part of the driver data not a global static.

> +/* DSP Mode */
> +static const char * const rt5670_dsp_mode[] = {
> +	"Mode 1", "Mode 2", "Mode 3", "Mode 4", "Mode 5"
> +};

What exactly are these modes?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141003/3d4e9e8a/attachment.sig>