[alsa-devel] [PATCH] ASoC: sgtl5000: Allow the codec to work in slave mode

[Mark Brown]

On Wed, Oct 01, 2014 at 03:44:59PM -0300, Fabio Estevam wrote:
> On Wed, Oct 1, 2014 at 3:27 PM, Mark Brown <broonie at kernel.org> wrote:

> > I'm sorry but I can't parse what you're saying terribly clearly - please
> > bear in mind that I don't know anything about this device, that's one of
> > the reasons I'm having to ask questions here.  If the configuration that
> > is being skipped is not about generating BCLK and LRCLK then it seems
> > like it's going to be wanted in slave mode as well as master.

> This patch does not skip any configuration. It just remove the error
> case for sgtl5000 in slave mode.

> Not sure why the error case was there in the first place, as I think
> sgtl5000 slave mode has never been tested before.

The comment says "if mclk not satisfy the divider, use pll" and then
does in fact skip configuring the PLL (or at least a register change
which looks like it does that).  Looking at the code it seems like
there's a requirement for MCLK to be one of the standard multiples of
the sample rate.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141002/dda94ea5/attachment.sig>