[alsa-devel] [PATCH 2/2] Signed-off-by: Jurgen Kramer <gtmkramer at xs4all.nl>

[Takashi Iwai]

At Fri, 28 Nov 2014 13:31:10 +0100,
Jurgen Kramer wrote:
> 
> add mode select quirk for Denon/Marantz DACs
> 
> Denon/Marantz USB DACs need a specific vendor command to switch between PCM and
> DSD mode. This patch adds a new quirk function to switch between the two modes
> using the specific USB vendor command.
> 
> This patch applies to the following devices:
> - Marantz SA-14S1
> - Marantz HD-DAC1
> 
> Signed-off-by: Jurgen Kramer <gtmkramer at xs4all.nl>

The subject line looks strange.

Just nitpicking:

> @@ -482,6 +482,12 @@ static int set_format(struct snd_usb_substream *subs, struct audioformat *fmt)
>  	/* set interface */
>  	if (subs->interface != fmt->iface ||
>  	    subs->altset_idx != fmt->altset_idx) {
> +
> +		err = snd_usb_select_mode_quirk(subs, fmt);
> +		if (err < 0) {
> +			return -EIO;
> +		}

No need for braces.


thanks,

Takashi