[alsa-devel] [PATCH 1/2] ALSA: firewire-lib: remove rx_blocks_for_midi quirk

[Takashi Sakamoto]

Clemens,

On Nov 26 2014 06:52, Clemens Ladisch wrote:
> There are several devices that expect to receive MIDI data only in the
> first eight data blocks of a packet.  If the driver restricts the data
> rate to the allowed rate (as mandated by the specification, but not yet
> implemented by this driver), this happens naturally.  Therefore, there
> is no reason to ever try to use more data packets with any device.
> 
> Signed-off-by: Clemens Ladisch <clemens at ladisch.de>
> ---
>  sound/firewire/amdtp.c                      |   10 +++++++---
>  sound/firewire/amdtp.h                      |    3 ---
>  sound/firewire/bebob/bebob_stream.c         |    7 -------
>  sound/firewire/fireworks/fireworks_stream.c |    5 -----
>  4 files changed, 7 insertions(+), 18 deletions(-)

Can I ask your opinion about applying this patch to devices with
non-blocking mode? At least, your comment of this patch is for blocking
mode (the fixed number of data blocks in a packet).


Regards

Takashi Sakamoto
o-takashi at sakamocchi.jp