[alsa-devel] [PATCH 0/9] ASoC: QCOM: Add support for ipq806x SOC

[Kenneth Westfield]

On Wed, November 19, 2014 12:16 pm, Kumar Gala wrote:
>
> On Nov 19, 2014, at 12:52 PM, Kenneth Westfield <kwestfie at codeaurora.org> wrote:
>
>> From: Kenneth Westfield <kwestfie at codeaurora.org>
>>
>> This set of patches adds support for audio on the Qualcomm Technologies
>> ipq806x SOC.
>>
>> The ipq806x SOC has audio-related hardware blocks in its low-power audio
>> subsystem (or LPASS).  One of the relevant blocks in the LPASS is its
>> low-power audio interface (or LPAIF).  This encapsulates the MI2S port,
>> which is what these drivers are configured to use.  The I2S pins are
>> connected to an external DAC/amp chip.  In addition, a single GPIO is
>> connected to the same DAC/amp, which gives the SOC enable/disable
>> control.
>>
>> The specific drivers added are:
>> - a machine driver that handles the board-specific pins
>> - a native driver that handles hardware access to the LPAIF
>> - a CPU DAI driver for controlling the LPAIF block
>> - a PCM MI2S platform driver
>>
>> Corresponding additions to the device tree for the ipq806x and its
>> documentation has also been added.  Also, as this is a new directory,
>> the MAINTAINERS file has been updated as well.
>>
>> - Ken
>
> Some general comments, you shouldn’t have gerrit Change-Id’s in commit messages, the
> Kconfig/Makefile changes should be part of the patch that adds the code associated with them.
>
> - k
>
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

Thank you for your comments.  I will separately address each comment shortly.

-- 
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project