[alsa-devel] [PATCH 02/29] ALSA: dice: Move file to its own directory

Clemens Ladisch clemens at ladisch.de
Tue Nov 18 13:57:27 CET 2014


Takashi Sakamoto wrote:
> In followed commits, dice driver is split into several files. For easily
> managing these files, this commit adds subdirectory and move file into
> the directory.

> -// TODO: rx index
> +/* TODO: rx index */

> -		event.dice_notification.type = SNDRV_FIREWIRE_EVENT_DICE_NOTIFICATION;
> +		event.dice_notification.type =
> +					SNDRV_FIREWIRE_EVENT_DICE_NOTIFICATION;

> -		count = min(count, (long)sizeof(event.dice_notification));
> +		count = min_t(long, count, sizeof(event.dice_notification));

> -static void dice_bus_reset(struct fw_unit *unit)
> +static void dice_update(struct fw_unit *unit)

Please mention these changes in the commit message, or move them into
a separate patch.


Regards,
Clemens


More information about the Alsa-devel mailing list