[alsa-devel] [PATCH 2/2] ASoC: rt5645: Add combo jack support

[Mark Brown]

On Fri, Oct 31, 2014 at 03:37:56PM +0800, bardliao at realtek.com wrote:

> @@ -2573,6 +2573,12 @@ static int rt5645_i2c_probe(struct i2c_client *i2c,
>  
>  	}
>  
> +	regmap_update_bits(rt5645->regmap, RT5645_IN1_CTRL1,
> +			   RT5645_CBJ_BST1_EN, RT5645_CBJ_BST1_EN);
> +	regmap_update_bits(rt5645->regmap, RT5645_JD_CTRL3,
> +			   RT5645_JD_CBJ_EN | RT5645_JD_CBJ_POL,
> +			   RT5645_JD_CBJ_EN | RT5645_JD_CBJ_POL);
> +

Is it really a good idea to enable this unconditionally - doesn't it
depend on the system hardware if this should be set up or how (the _POL
looks like a polarity setting for example)?  I'd expect it to at least
waste power.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141107/e03cac2b/attachment.sig>