[alsa-devel] [PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

Mark Brown broonie at kernel.org
Fri Nov 7 12:17:37 CET 2014


On Thu, Nov 06, 2014 at 05:39:45PM +0100, Peter Rosin wrote:

> +	{ TFA9879_MISC_STATUS,		0x0000 }, /* 0x15, read-only */

The fix here is the wrong way round - if the device is reporting status
here there should be no default and there should be a volatile operation
(though it's not the end of the world to omit that if it's not used).

Otherwise this looks good.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141107/a1415f20/attachment.sig>


More information about the Alsa-devel mailing list