[alsa-devel] [PATCH 3/4] ASoC:rt5670: add rt5672 codec support

[Mark Brown]

On Thu, Nov 06, 2014 at 12:23:53PM +0800, bardliao at realtek.com wrote:

> +	case RT5670_ID_5670:
> +	case RT5670_ID_5671:

This looks like it also adds rt5671 support but...

>  static const struct i2c_device_id rt5670_i2c_id[] = {
>  	{ "rt5670", 0 },
> +	{ "rt5672", 0 },
>  	{ }
>  };

...not here.  Otherwise this is fine, though it would be better to warn
if the user registered the device as one type but it turns out to be
another when we read the ID register.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141106/484caa4b/attachment.sig>