[alsa-devel] [PATCH] ASoC:rt286: set combo jack by dmi

[Mark Brown]

On Wed, Nov 05, 2014 at 01:09:26PM +0800, bardliao at realtek.com wrote:

> +static struct dmi_system_id intel_platform[] __initdata = {
> +	{

This is fine but can you please rename the variable from intel_platform
to something more meaningful like the name of the reference design these
are derived from or something?  That way if we need to add some other
quirk (and I guess we will) we won't have to rename this table - I guess
anything that's using a DMI quirk will be some Intel based platform.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141105/4fb303c3/attachment.sig>