[alsa-devel] Restore hidden register for default value

[Takashi Iwai]

At Wed, 5 Nov 2014 07:20:06 +0000,
Kailang wrote:
> 
>  Hi Takashi,
> 
>  I mail it again.

Oh, your previous post didn't include the patch, so I just waited for
it.

Now I took a look at the patch.  One thing I'd like to change is the
place to set spec->init_hook.  It'd be better to set around the code
where alc662_fill_coef is passed.  Since ALC668 is irrelevant with
this, move the switch/case there, apply both spec->init_hook
conditionally.


thanks,

Takashi

> 
> BR,
> Kailang
> 
> > -----Original Message-----
> > From: Kailang 
> > Sent: Friday, October 31, 2014 3:12 PM
> > To: 'Takashi Iwai'
> > Cc: (alsa-devel at alsa-project.org)
> > Subject: RE: Restore hidden register for default value
> > 
> > Hi Takashi,
> > 
> > It's just the default value refill in initial state.
> > It's only for ALC668(ALC3661).
> > The patch was tested pass with issue machine in ODM site.
> > 
> > Many Thanks.
> > 
> > BR,
> > Kailang
> > 
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai at suse.de]
> > > Sent: Wednesday, October 22, 2014 4:00 PM
> > > To: Kailang
> > > Subject: Re: Restore hidden register for default value
> > > 
> > > At Wed, 22 Oct 2014 07:56:43 +0000,
> > > Kailang wrote:
> > > > 
> > > > Hi Takashi,
> > > > 
> > > > We want to post ALC668 for hidden register issue.
> > > > 
> > > > Could I post like below array for codec initial state?
> > > > 
> > > > WORD coefIndexDefault[][2] = {{0x1,
> > > 0xbebe},{0x2,0xaaaa},{0x3,0x0},{0x4,0x180},{0x6,0x0},
> > > >           
> > > {0x7,0xf80},{0x8,0x31},{0xa,0x60},{0xb,0x0},{0xc,0x7cf7},{0xd,
> > >  0x1080},{0xe,0x7f7f},
> > > >           
> > > {0xf,0xcccc},{0x10,0xddcc},{0x11,0x1},{0x13,0x0},{0x14,0x2aa0}
> > > ,{0x17,0xA940},
> > > >           
> > > {0x19,0},{0x1A,0},{0x1B,0},{0x1c,0x0},{0x1d,0x0},{0x1e,0x7418}
> > > ,{0x1f,0x804},
> > > >           
> > > {0x20,0x4200},{0x21,0x468},{0x22,0x8ccc},{0x23,0x250},{0x24,0x7418},
> > > >           
> > > > 
> > > 
> > {0x27,0x0000},{0x28,0x8ccc},{0x2a,0xff00},{0x2b,0x8000},{0xa7,0xff00}}
> > > > ; Because codec sometimes has wrong value for hidden 
> > register after 
> > > > resume back or reboot.
> > > > It needed to refill the default value with upper array in
> > > initial state.
> > > > But the hidden registers was more for 59 records.
> > > > Could I post it with no remark? Because it just the default
> > > value. Thanks.
> > > 
> > > Some comments would be nice, of course, but not mandatory.
> > > 
> > > One concern is exactly which codecs should this be applied.  
> > > There are a bunch of codecs compatible with alc668.  It's only for 
> > > ALC668, and not for others (ALC668, 670, whatever).
> > > 
> > > 
> > > Takashi
> > > 
> > > ------Please consider the environment before printing this e-mail.
> > > 
> [2 0000-alc668-restore-default.patch <application/octet-stream (base64)>]
>