[alsa-devel] ALSA: echoaudio: remove all snd_printk

Dan Carpenter dan.carpenter at oracle.com
Tue Nov 4 17:01:56 CET 2014


Hello Sudip Mukherjee,

The patch b5b4a41b3929: "ALSA: echoaudio: remove all snd_printk" from
Nov 3, 2014, leads to the following static checker warning:

	sound/pci/echoaudio/echoaudio.c:1908 snd_echo_free()
	error: dereferencing freed memory 'chip'

sound/pci/echoaudio/echoaudio.c
  1905          /* release chip data */
  1906          free_firmware_cache(chip);
  1907          kfree(chip);
                ^^^^^^^^^^^
  1908          dev_dbg(chip->card->dev, "Chip freed.\n");
                        ^^^^^^^^^^

We have lots of printks in this function.  We could just delete them all
and no one would care.  These days you can get the same information from
ftrace.

  1909          return 0;
  1910  }

regards,
dan carpenter


More information about the Alsa-devel mailing list