[alsa-devel] [PATCH v2 5/5] ASoC: Intel: add BYTCR machine driver with RT5640

[Vinod Koul]

On Tue, Nov 04, 2014 at 11:19:10AM +0200, Jarkko Nikula wrote:
> On 11/04/2014 07:31 AM, Vinod Koul wrote:
> >From: Subhransu S. Prusty <subhransu.s.prusty at intel.com>
> >
> >Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty at intel.com>
> >Signed-off-by: Vinod Koul <vinod.koul at intel.com>
> >---
> >  sound/soc/intel/Kconfig             |   12 ++
> >  sound/soc/intel/Makefile            |    2 +
> >  sound/soc/intel/bytcr_dpcm_rt5640.c |  258 +++++++++++++++++++++++++++++++++++
> >  3 files changed, 272 insertions(+), 0 deletions(-)
> >  create mode 100644 sound/soc/intel/bytcr_dpcm_rt5640.c
> >
> ...
> >+static const struct snd_kcontrol_new byt_mc_controls[] = {
> >+	SOC_DAPM_PIN_SWITCH("Headphone"),
> >+	SOC_DAPM_PIN_SWITCH("Headset Mic"),
> >+	SOC_DAPM_PIN_SWITCH("Int Mic"),
> >+	SOC_DAPM_PIN_SWITCH("Ext Spk"),
> >+};
> ...
> >+static struct snd_soc_dai_link byt_dailink[] = {
> >+	[MERR_DPCM_AUDIO] = {
> >+		.name = "Baytrail Audio Port",
> >+		.stream_name = "Baytrail Audio",
> >
> ...
> >+/* SoC card */
> >+static struct snd_soc_card snd_soc_card_byt = {
> >+	.name = "baytrailcraudio",
> >
> I think it's worth to have same kcontrol and card names than
> byt-rt5640 in case this is going to replace byt-rt5640.c since then
> users can continue to use the same asound.state file. E.g. speakers
> won't mute because of "Speaker" changes to "Ext Spk".
It would have helped if the DSP controls were not there. The DSP controls
need to be routed too, so existing conf files would need to be updated.

So, do you still recommend changing :)

-- 
~Vinod