[alsa-devel] [PATCH] ASoC: Intel: Add Merrifield machine driver

[Mark Brown]

On Mon, Nov 03, 2014 at 10:31:58AM +0530, Vinod Koul wrote:
> On Fri, Oct 31, 2014 at 05:11:27PM +0000, Mark Brown wrote:

> > > +	snd_jack_set_key(ctx->jack.jack, SND_JACK_BTN_1, KEY_MEDIA);
> > > +	snd_jack_set_key(ctx->jack.jack, SND_JACK_BTN_0, KEY_MEDIA);

> > Two buttons both reporting the same key?  Might be worth a comment.

> Okay loooking back I am not sure why we added two here, let me check and
> clean this up.

I was assuming it was because the tolerance desired on the button was
wider than a single detection range on the device so this was ensuring
that the button was reliably detected.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141103/7f29585e/attachment.sig>