[alsa-devel] [PATCH] bebob: Use ARRAY_SIZE() instead of sizeof() for return condition

Takashi Iwai tiwai at suse.de
Sat May 31 09:34:02 CEST 2014


At Sat, 31 May 2014 15:33:52 +0900,
Takashi Sakamoto wrote:
> 
> The parser for stream format information should return when detecting wrong
> value for sampling rate. But it doesn't.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

This was already fixed by Dan's patch.


thanks,

Takashi


> ---
>  sound/firewire/bebob/bebob_stream.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/firewire/bebob/bebob_stream.c b/sound/firewire/bebob/bebob_stream.c
> index 514c7c9..bc4f827 100644
> --- a/sound/firewire/bebob/bebob_stream.c
> +++ b/sound/firewire/bebob/bebob_stream.c
> @@ -749,7 +749,7 @@ parse_stream_formation(u8 *buf, unsigned int len,
>  		if (buf[2] == bridgeco_freq_table[i])
>  			break;
>  	}
> -	if (i == sizeof(bridgeco_freq_table))
> +	if (i == ARRAY_SIZE(bridgeco_freq_table))
>  		return -ENOSYS;
>  
>  	/* Avoid double count by different entries for the same rate. */
> -- 
> 1.8.3.2
> 


More information about the Alsa-devel mailing list