[alsa-devel] [PATCH] ALSA: hda: fix tegra build
Arnd Bergmann
arnd at arndb.de
Mon May 26 21:10:30 CEST 2014
On Monday 26 May 2014, Takashi Iwai wrote:
> At Mon, 26 May 2014 18:14:21 +0200,
> Arnd Bergmann wrote:
> >
> > When CONFIG_PM is disabled, the CONFIG_SND_HDA_POWER_SAVE_DEFAULT symbol
> > does not get defined, which causes a build error for the hda-tegra driver:
> >
> > hda/hda_tegra.c:80:25: error: 'CONFIG_SND_HDA_POWER_SAVE_DEFAULT' undeclared here (not in a function)
> > static int power_save = CONFIG_SND_HDA_POWER_SAVE_DEFAULT;
> > ^
> > /git/arm-soc/sound/pci/hda/hda_tegra.c:235:13: warning: 'hda_tegra_disable_clocks' defined but not used [-Wunused-function]
> > static void hda_tegra_disable_clocks(struct hda_tegra *data)
> > ^
> >
> > This works around the problem by not referencing that macro
> > when CONFIG_PM is disabled. Instead, we assume that it's disabled
> > unconditionally and cannot be enabled at runtime.
> >
> > Signed-off-by: Dylan Reid <dgreid at chromium.org>
> > Reviewed-by: Stephen Warren <swarren at nvidia.com>
> > Signed-off-by: Takashi Iwai <tiwai at suse.de>
>
> Oh, you cloned me?
>
Damn, copy-paste error on my side. All three are wrong and should be Cc:,
also my Signed-off-by is missing.
Let me resend.
Arnd
More information about the Alsa-devel
mailing list