[alsa-devel] [PATCH v4 12/17] ASoC: fsl-ssi: set bitclock in master mode from hw_params

[Mark Brown]

On Mon, Apr 28, 2014 at 12:54:53PM +0200, Markus Pargmann wrote:
> From: Sascha Hauer <s.hauer at pengutronix.de>
> 
> The fsl_ssi driver uses the .set_sysclk callback to configure the
> bitclock for master mode. This is unnecessary since the bitclock
> is known in hw_params. This patch removes the .set_sysclk callback
> and configures the bitclock from .hw_params.
> 
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---

This isn't signed off either.  Are we positive that none of the users
set the bitclock to something non-default - there are devices out there
which require an unusual bitclock (eg, where it's also used as the
master clock and so needs overclocking)?

Providing a default as this does is a definite win, but allowing it to
be overridden may be needed sometimes (rarely fortunately).  Leaving a
stub set_sysclk() that just sets a variable and then using that value
instead of calculating in hw_params() would get the best of both worlds.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140520/36dbe8fb/attachment-0001.sig>