[alsa-devel] [PATCH] ASoC: sta350: Add codec driver
Daniel Mack
zonque at gmail.com
Thu Mar 27 20:43:12 CET 2014
Hi Mark,
On 03/27/2014 06:21 PM, Mark Brown wrote:
> On Thu, Mar 27, 2014 at 05:18:02PM +0100, Daniel Mack wrote:
>> From: Sven Brandau <brandau at gmx.de>
>>
>> The TI STA350 is an integrated 2.1-channel power amplifier that is
>> controllable over I2C. This patch adds an ASoC driver for it.
>>
>> At a glance, this chip is very similar to the STA320 for which a driver
>> already exists. In details, however, the register maps contain subtle
>> differences which made a whole new driver easier to write and maintain.
>
> A few issues below, some may already be present in the sta320 driver,
> generally newer idioms and so on, but that's no reason to not fix them
> here!
Thanks a lot for your review! Much appreciated.
All points are agreed upon, and are already fixed locally. Will send a
v2 soon.
Daniel
More information about the Alsa-devel
mailing list