[alsa-devel] [PATCH] ASoC: add RT5639 CODEC driver

[Oder Chiou]

> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Tuesday, March 25, 2014 9:30 PM
> To: Oder Chiou
> Cc: lgirdwood at gmail.com; alsa-devel at alsa-project.org; Flove; Bard Liao
> Subject: Re: [PATCH] ASoC: add RT5639 CODEC driver
> 
> On Mon, Mar 24, 2014 at 10:16:37AM +0800, oder_chiou at realtek.com wrote:
> > From: Oder Chiou <oder_chiou at realtek.com>
> >
> > This patch adds the RT5639 codec driver.
> 
> Looking at the level of code similiarity between this and the rt5640 driver I can't
> help but think that these should be supported from a single driver - a few quick
> spot checks of the register map suggests that there's at least some overlap.
> There will need to be some device specific handling but it looks like there's more
> shared than not shared.
> What are the issues that prevent the code being shared, there may be something
> I've missed?
> 

We will merge the RT5639 driver to RT5640.

> > +static int rt5639_probe(struct snd_soc_codec *codec) {
> > +	struct rt5639_priv *rt5639 = snd_soc_codec_get_drvdata(codec);
> > +	int ret;
> > +
> > +	rt5639->codec = codec;
> > +	codec->control_data = rt5639->regmap;
> > +
> > +	ret = snd_soc_codec_set_cache_io(codec, 8, 16, SND_SOC_REGMAP);
> > +	if (ret != 0) {
> > +		dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret);
> > +		return ret;
> > +	}
> 
> There have been some API changes here this release cycle, you should be able to
> just remove the cache_io() and regmap setting code here.

Do you mean that the cache_io() can be removed here?
Please tell us which codec driver can be for our reference, thank you.