[alsa-devel] [RFC v2 PATCH] ASoC: wm8904: add CCF support

Mark Brown broonie at kernel.org
Tue Mar 25 12:27:16 CET 2014


On Tue, Mar 25, 2014 at 05:56:56PM +0800, Bo Shen wrote:

>  	case SND_SOC_BIAS_ON:
> +		if (IS_ENABLED(CONFIG_COMMON_CLK))
> +			if (wm8904->mclk)
> +				clk_prepare_enable(wm8904->mclk);

No, this shouldn't depend on COMMON_CLK - there is no reason other clock
API implementations shouldn't be able to use this.  Providing a clock is
something you can only do with COMMON_CLK but using one doesn't need
that, generally using a clock is done unconditionally.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140325/7949b8d6/attachment.sig>


More information about the Alsa-devel mailing list